fix(windows): classify UASP storage as USB - #1682
Merged
tdewey-rpi merged 1 commit intoAug 7, 2026
Merged
Conversation
elibosley
marked this pull request as ready for review
August 6, 2026 00:28
tdewey-rpi
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows UASP storage can be hidden as a system SCSI disk; this classifies SCSI-enumerated devices with an authoritative USB bus type as USB before applying the system-drive heuristic.
Why This Exists
Windows exposes many USB 3 storage bridges through the SCSI enumerator when they use UASP. Enumerator-only classification therefore leaves
isUSBfalse, and a non-removable UASP target can be guessed to be a system drive and hidden from the storage list.Resolution
Use the adapter descriptor bus type already collected by the device scan. When the enumerator is SCSI and
busTypeis USB, mark the device as USB before the existing system-drive classification. The later authoritative system-disk override remains unchanged.Reviewer Considerations
SCSI\DISK.Behavior Changes
UASP-attached removable storage appears in the Windows storage list instead of being hidden by the generic SCSI system-drive heuristic.
Implementation Summary
isUSBfrom the SCSI enumerator plus USB adapter bus type before system-drive classification.Verification
git diff --check: passed.Risk
Low. The adapter bus type is authoritative, and the existing final system-disk override is preserved.