Repository navigation
Fix \param names in interp_get_base and riscv_timer_set_mtimecmp - #3165
Merged
Merged
Conversation
lurch
approved these changes
Sep 1, 2026
Contributor
Well that's a bit annoying 🙁 |
Contributor
Author
|
I was wrong about that. It does warn, I just checked with 1.18 against the defaults Both of those, and then it exits 0. So the docs job stays green and the two lines scroll past with everything else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was checking doxygen output on the interp and riscv timer headers and hit two \param names that don't match the argument below them. interp_get_base documents
lane, which looks copied from interp_set_base just above it, and riscv_timer_set_mtimecmp documentsmtimefrom its neighbour. Doxygen drops unmatched names quietly so the build stays green either way. I left the mtimecmp wording alone, it still reads as if the call sets mtime and that seemed like your call.