Locking LogConversation when set centrally

rappen · rappen · commit f2ffcabdcc54 · 2025-09-23T20:40:08.000+02:00
diff --git a/FetchXmlBuilder/DockControls/AiChatControl.cs b/FetchXmlBuilder/DockControls/AiChatControl.cs
@@ -32,6 +32,7 @@ public partial class AiChatControl : WeifenLuo.WinFormsUI.Docking.DockContent
         private Stopwatch callingstopwatch;
         private Dictionary<string, List<MetadataForAIAttribute>> metaAttributes = new Dictionary<string, List<MetadataForAIAttribute>>();
         private string logname = "AI";
+        private bool logconversation = false;
         private int manualcalls = 0; // Counts the number of calls made by the user in this session
         private static List<AiUser> freeusers;
 
@@ -108,6 +109,7 @@ internal void Initialize()
             {
                 apikey = fxb.settings.AiSettings.ApiKey;
             }
+            logconversation = model.LogConversation ?? fxb.settings.AiSettings.LogConversation;
             chatHistory = new ChatMessageHistory(panAiConversation, supplier?.Name, model?.Endpoint, model?.Name, apikey, fxb.settings.AiSettings.MyName);
             metaAttributes.Clear();
             SetTitle();
@@ -490,7 +492,7 @@ private void Log(string action, double? count = null, double? duration = null, l
             {
                 ai = new AIAppInsights(fxb, OnlineSettings.Instance.AiSupport.AppRegistrationEndpoint, OnlineSettings.Instance.AiSupport.InstrumentationKey, supplier.Name, model.Name);
             }
-            ai.WriteEvent($"{action}", count ?? msg?.Length, duration, tokensout, tokensin, fxb.settings.AiSettings.LogConversation ? msg : null);
+            ai.WriteEvent($"{action}", count ?? msg?.Length, duration, tokensout, tokensin, logconversation ? msg : null);
         }
 
         #endregion Private Methods
diff --git a/FetchXmlBuilder/Forms/Settings.Designer.cs b/FetchXmlBuilder/Forms/Settings.Designer.cs
diff --git a/FetchXmlBuilder/Forms/Settings.cs b/FetchXmlBuilder/Forms/Settings.cs
@@ -379,6 +379,17 @@ private void cmbAiModel_SelectedIndexChanged(object sender = null, EventArgs e =
                     LoadAiSettingsKey();
                 }
                 txtAiApiKey.Enabled = !supplier.Free;
+                if (model.LogConversation != null)
+                {
+                    chkAiLogConversation.Checked = model.LogConversation.Value;
+                    chkAiLogConversation.Enabled = false;
+                    tt.SetToolTip(picAiLogConversation, $"The setting for logging conversations is determined by{Environment.NewLine}Supplier: {supplier} and{Environment.NewLine}Model: {model}{Environment.NewLine}and cannot be changed manually.");
+                }
+                else
+                {
+                    chkAiLogConversation.Enabled = true;
+                    tt.SetToolTip(picAiLogConversation, $"If checked, the conversation will be logged to Application Insights.");
+                }
             }
             else
             {
@@ -412,9 +423,12 @@ private void linkLogFolder_LinkClicked(object sender, LinkLabelLinkClickedEventA
             Process.Start("explorer.exe", linkAiLogFolder.Text);
         }
 
-        private void picAiLogFolder_Click(object sender, EventArgs e)
+        private void picAiLog_Click(object sender, EventArgs e)
         {
-            MessageBoxEx.Show(this, tt.GetToolTip(picAiLogFolder), "Information", MessageBoxButtons.OK, MessageBoxIcon.Information);
+            if (sender is PictureBox pic)
+            {
+                MessageBoxEx.Show(this, tt.GetToolTip(pic), "Information", MessageBoxButtons.OK, MessageBoxIcon.Information);
+            }
         }
     }
 }
diff --git a/FetchXmlBuilder/Forms/Settings.resx b/FetchXmlBuilder/Forms/Settings.resx
@@ -120,6 +120,18 @@
   <metadata name="tt.TrayLocation" type="System.Drawing.Point, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a">
     <value>17, 17</value>
   </metadata>
+  <data name="picAiLogConversation.ToolTip" xml:space="preserve">
+    <value>Every session in the conversation to the AI is stored in this folder.
+The conversation is not only what you can see in the UI,
+but also internal messages back and forth, e.g. the metadata
+that the AI may need.
+This logging is not used by the tool, you may clean the
+folder whenever you want to, this is just to give you the
+opportunity to learn even more, to see what the AI is asking
+the tool about.
+Note that this type of detail logs are only stored locally, not
+in any external system!</value>
+  </data>
   <data name="picAiLogFolder.ToolTip" xml:space="preserve">
     <value>Every session in the conversation to the AI is stored in this folder.
 The conversation is not only what you can see in the UI,
diff --git a/Rappen.XTB.Helper b/Rappen.XTB.Helper
@@ -1 +1 @@
-Subproject commit a9558569786d3c41c28a39d3e40ba3d65a7ea0c0
+Subproject commit 6a48fa6bbecad8b27ee07dd80c123e9ee5257c5c

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,7 @@ public partial class AiChatControl : WeifenLuo.WinFormsUI.Docking.DockContent`
`32`	`32`	`private Stopwatch callingstopwatch;`
`33`	`33`	`private Dictionary<string, List<MetadataForAIAttribute>> metaAttributes = new Dictionary<string, List<MetadataForAIAttribute>>();`
`34`	`34`	`private string logname = "AI";`
	`35`	`+ private bool logconversation = false;`
`35`	`36`	`private int manualcalls = 0; // Counts the number of calls made by the user in this session`
`36`	`37`	`private static List<AiUser> freeusers;`
`37`	`38`
`@@ -108,6 +109,7 @@ internal void Initialize()`
`108`	`109`	`{`
`109`	`110`	`apikey = fxb.settings.AiSettings.ApiKey;`
`110`	`111`	`}`
	`112`	`+ logconversation = model.LogConversation ?? fxb.settings.AiSettings.LogConversation;`
`111`	`113`	`chatHistory = new ChatMessageHistory(panAiConversation, supplier?.Name, model?.Endpoint, model?.Name, apikey, fxb.settings.AiSettings.MyName);`
`112`	`114`	`metaAttributes.Clear();`
`113`	`115`	`SetTitle();`
`@@ -490,7 +492,7 @@ private void Log(string action, double? count = null, double? duration = null, l`
`490`	`492`	`{`
`491`	`493`	`ai = new AIAppInsights(fxb, OnlineSettings.Instance.AiSupport.AppRegistrationEndpoint, OnlineSettings.Instance.AiSupport.InstrumentationKey, supplier.Name, model.Name);`
`492`	`494`	`}`
`493`		`- ai.WriteEvent($"{action}", count ?? msg?.Length, duration, tokensout, tokensin, fxb.settings.AiSettings.LogConversation ? msg : null);`
	`495`	`+ ai.WriteEvent($"{action}", count ?? msg?.Length, duration, tokensout, tokensin, logconversation ? msg : null);`
`494`	`496`	`}`
`495`	`497`
`496`	`498`	`#endregion Private Methods`
Original file line number	Diff line number	Diff line change
`@@ -379,6 +379,17 @@ private void cmbAiModel_SelectedIndexChanged(object sender = null, EventArgs e =`
`379`	`379`	`LoadAiSettingsKey();`
`380`	`380`	`}`
`381`	`381`	`txtAiApiKey.Enabled = !supplier.Free;`
	`382`	`+ if (model.LogConversation != null)`
	`383`	`+ {`
	`384`	`+ chkAiLogConversation.Checked = model.LogConversation.Value;`
	`385`	`+ chkAiLogConversation.Enabled = false;`
	`386`	`+ tt.SetToolTip(picAiLogConversation, $"The setting for logging conversations is determined by{Environment.NewLine}Supplier: {supplier} and{Environment.NewLine}Model: {model}{Environment.NewLine}and cannot be changed manually.");`
	`387`	`+ }`
	`388`	`+ else`
	`389`	`+ {`
	`390`	`+ chkAiLogConversation.Enabled = true;`
	`391`	`+ tt.SetToolTip(picAiLogConversation, $"If checked, the conversation will be logged to Application Insights.");`
	`392`	`+ }`
`382`	`393`	`}`
`383`	`394`	`else`
`384`	`395`	`{`
`@@ -412,9 +423,12 @@ private void linkLogFolder_LinkClicked(object sender, LinkLabelLinkClickedEventA`
`412`	`423`	`Process.Start("explorer.exe", linkAiLogFolder.Text);`
`413`	`424`	`}`
`414`	`425`
`415`		`- private void picAiLogFolder_Click(object sender, EventArgs e)`
	`426`	`+ private void picAiLog_Click(object sender, EventArgs e)`
`416`	`427`	`{`
`417`		`- MessageBoxEx.Show(this, tt.GetToolTip(picAiLogFolder), "Information", MessageBoxButtons.OK, MessageBoxIcon.Information);`
	`428`	`+ if (sender is PictureBox pic)`
	`429`	`+ {`
	`430`	`+ MessageBoxEx.Show(this, tt.GetToolTip(pic), "Information", MessageBoxButtons.OK, MessageBoxIcon.Information);`
	`431`	`+ }`
`418`	`432`	`}`
`419`	`433`	`}`
`420`	`434`	`}`