Simplifying link opening

rappen · rappen · commit 6dbdba87cfc6 · 2024-04-03T17:05:15.000+02:00
diff --git a/FetchXmlBuilder/FXBGui.cs b/FetchXmlBuilder/FXBGui.cs
@@ -196,12 +196,18 @@ internal void ShowMetadata(MetadataBase meta)
             }
         }
 
+        internal void HelpClick(object sender, EventArgs e) => HelpClick(sender);
+
         internal static void HelpClick(object sender)
         {
             if (sender is Control control && control.Tag is string tag)
             {
                 HelpClick(tag);
             }
+            else if (sender is ToolStripItem tsi && tsi.Tag is string tsitag)
+            {
+                HelpClick(tsitag);
+            }
         }
 
         internal static void HelpClick(string url)
diff --git a/FetchXmlBuilder/FetchXmlBuilder.Designer.cs b/FetchXmlBuilder/FetchXmlBuilder.Designer.cs
diff --git a/FetchXmlBuilder/FetchXmlBuilder.cs b/FetchXmlBuilder/FetchXmlBuilder.cs
@@ -878,18 +878,6 @@ private void tsbShare_Click(object sender, EventArgs e)
             ShareLink.Open(this, dockControlBuilder.GetFetchString(false, false));
         }
 
-        private void LinkButton_Click(object sender, EventArgs e)
-        {
-            if (sender is ToolStripItem tsi && tsi.Tag is string tag1 && tag1.StartsWith("http") == true)
-            {
-                OpenURL(tag1);
-            }
-            else if (sender is Control control && control.Tag is string tag2 && tag2.StartsWith("http") == true)
-            {
-                OpenURL(tag2);
-            }
-        }
-
         #endregion Private Event Handlers
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -196,12 +196,18 @@ internal void ShowMetadata(MetadataBase meta)`
`196`	`196`	`}`
`197`	`197`	`}`
`198`	`198`
	`199`	`+ internal void HelpClick(object sender, EventArgs e) => HelpClick(sender);`
	`200`	`+`
`199`	`201`	`internal static void HelpClick(object sender)`
`200`	`202`	`{`
`201`	`203`	`if (sender is Control control && control.Tag is string tag)`
`202`	`204`	`{`
`203`	`205`	`HelpClick(tag);`
`204`	`206`	`}`
	`207`	`+ else if (sender is ToolStripItem tsi && tsi.Tag is string tsitag)`
	`208`	`+ {`
	`209`	`+ HelpClick(tsitag);`
	`210`	`+ }`
`205`	`211`	`}`
`206`	`212`
`207`	`213`	`internal static void HelpClick(string url)`
Original file line number	Diff line number	Diff line change
`@@ -878,18 +878,6 @@ private void tsbShare_Click(object sender, EventArgs e)`
`878`	`878`	`ShareLink.Open(this, dockControlBuilder.GetFetchString(false, false));`
`879`	`879`	`}`
`880`	`880`
`881`		`- private void LinkButton_Click(object sender, EventArgs e)`
`882`		`- {`
`883`		`- if (sender is ToolStripItem tsi && tsi.Tag is string tag1 && tag1.StartsWith("http") == true)`
`884`		`- {`
`885`		`- OpenURL(tag1);`
`886`		`- }`
`887`		`- else if (sender is Control control && control.Tag is string tag2 && tag2.StartsWith("http") == true)`
`888`		`- {`
`889`		`- OpenURL(tag2);`
`890`		`- }`
`891`		`- }`
`892`		`-`
`893`	`881`	`#endregion Private Event Handlers`
`894`	`882`	`}`
`895`	`883`	`}`