Fixed #984 Don't ask about comment if no comments

rappen · rappen · commit 5a02a3123f17 · 2023-11-05T14:45:44.000+01:00
diff --git a/FetchXmlBuilder/DockControls/XmlContentControl.cs b/FetchXmlBuilder/DockControls/XmlContentControl.cs
@@ -316,7 +316,11 @@ private void FormatAsMini()
                 FormatAsXML();
             }
             var fetchxml = txtXML.Text;
-            var removecomm = MessageBox.Show("Remove comments?", "Minify XML", MessageBoxButtons.YesNo, MessageBoxIcon.Question) == DialogResult.Yes;
+            var removecomm = false;
+            if (fetchxml.Contains("<!--"))
+            {
+                removecomm = MessageBox.Show("Remove comments?", "Minify XML", MessageBoxButtons.YesNo, MessageBoxIcon.Question) == DialogResult.Yes;
+            }
             string result = GetFetchMini(fetchxml, fxb.settings.QueryOptions.UseSingleQuotation ? '\'' : '"', removecomm);
             txtXML.Text = result;
         }

Original file line number	Diff line number	Diff line change
`@@ -316,7 +316,11 @@ private void FormatAsMini()`
`316`	`316`	`FormatAsXML();`
`317`	`317`	`}`
`318`	`318`	`var fetchxml = txtXML.Text;`
`319`		`- var removecomm = MessageBox.Show("Remove comments?", "Minify XML", MessageBoxButtons.YesNo, MessageBoxIcon.Question) == DialogResult.Yes;`
	`319`	`+ var removecomm = false;`
	`320`	`+ if (fetchxml.Contains("<!--"))`
	`321`	`+ {`
	`322`	`+ removecomm = MessageBox.Show("Remove comments?", "Minify XML", MessageBoxButtons.YesNo, MessageBoxIcon.Question) == DialogResult.Yes;`
	`323`	`+ }`
`320`	`324`	`string result = GetFetchMini(fetchxml, fxb.settings.QueryOptions.UseSingleQuotation ? '\'' : '"', removecomm);`
`321`	`325`	`txtXML.Text = result;`
`322`	`326`	`}`