Skip to content

[Improvement] Fetch runtime version with cuda-python instead of numba - #1675

Closed
Matt711 wants to merge 4 commits into
rapidsai:branch-25.02from
Matt711:improvement/fetch-runtime-version-with-cuda-python
Closed

[Improvement] Fetch runtime version with cuda-python instead of numba#1675
Matt711 wants to merge 4 commits into
rapidsai:branch-25.02from
Matt711:improvement/fetch-runtime-version-with-cuda-python

Conversation

@Matt711

@Matt711 Matt711 commented Sep 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Closes #948

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711
Matt711 requested a review from a team as a code owner September 9, 2024 23:24
@github-actions github-actions Bot added the Python Related to RMM Python API label Sep 9, 2024
harrism
harrism approved these changes Sep 9, 2024
View reviewed changes

@harrism harrism left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@harrism harrism added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Sep 9, 2024
@Matt711

Matt711 commented Sep 10, 2024

Copy link
Copy Markdown
Contributor Author

Okay CI is failing is failing because cuda.cudart.getLocalRuntimeVersion() is raising a RuntimeError in cuda 11.8 devcontainer.

In [1]: from cuda import cudart

In [2]: cudart.getLocalRuntimeVersion()
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
Cell In[2], line 1
----> 1 cudart.getLocalRuntimeVersion()

File ~/.conda/envs/rapids/lib/python3.11/site-packages/cuda/cudart.pyx:24961, in cuda.cudart.getLocalRuntimeVersion()

File ~/.conda/envs/rapids/lib/python3.11/site-packages/cuda/ccudart.pyx:2365, in cuda.ccudart.getLocalRuntimeVersion()

File ~/.conda/envs/rapids/lib/python3.11/site-packages/cuda/_lib/ccudart/ccudart.pyx:2121, in cuda._lib.ccudart.ccudart._getLocalRuntimeVersion()

RuntimeError: Failed to dlopen libcudart.so.12

@Matt711 Matt711 mentioned this pull request Sep 10, 2024
Closed
@Matt711

Matt711 commented Sep 11, 2024

Copy link
Copy Markdown
Contributor Author

Okay CI is failing is failing because cuda.cudart.getLocalRuntimeVersion() is raising a RuntimeError in cuda 11.8 devcontainer.

In [1]: from cuda import cudart

In [2]: cudart.getLocalRuntimeVersion()
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
Cell In[2], line 1
----> 1 cudart.getLocalRuntimeVersion()

File ~/.conda/envs/rapids/lib/python3.11/site-packages/cuda/cudart.pyx:24961, in cuda.cudart.getLocalRuntimeVersion()

File ~/.conda/envs/rapids/lib/python3.11/site-packages/cuda/ccudart.pyx:2365, in cuda.ccudart.getLocalRuntimeVersion()

File ~/.conda/envs/rapids/lib/python3.11/site-packages/cuda/_lib/ccudart/ccudart.pyx:2121, in cuda._lib.ccudart.ccudart._getLocalRuntimeVersion()

RuntimeError: Failed to dlopen libcudart.so.12

We can merge this PR after NVIDIA/cuda-python#89 is closed.

@Matt711 Matt711 self-assigned this Sep 12, 2024
@Matt711
Matt711 changed the base branch from branch-24.10 to branch-24.12 September 24, 2024 12:41
@wence- wence- added the 0 - Blocked Cannot progress due to external reasons label Sep 30, 2024
@harrism

harrism commented Nov 19, 2024

Copy link
Copy Markdown
Member

This will need to move to 25.02. But is it unblocked now that NVIDIA/cuda-python#89 closed?

@Matt711

Matt711 commented Nov 19, 2024

Copy link
Copy Markdown
Contributor Author

This will need to move to 25.02. But is it unblocked now that NVIDIA/cuda-python#89 closed?

Yes, I think it also needs #1729

@wence-
wence- changed the base branch from branch-24.12 to branch-25.02 November 28, 2024 15:27
@wence-

wence- commented Nov 28, 2024

Copy link
Copy Markdown
Contributor

Note that I think this means that numba can now be an optional installation dependency, rather than a required one.

This was referenced Dec 5, 2024
Merged
Closed
Closed
Merged
@Matt711

Matt711 commented Dec 10, 2024

Copy link
Copy Markdown
Contributor Author

The changes in this PR have incorporated into #1756

@Matt711 Matt711 closed this Dec 10, 2024
rapids-bot Bot pushed a commit that referenced this pull request Dec 10, 2024
@bdice
Use bindings layout for all cuda-python imports. (#1756)
c3841dd 
Closes #1755.

Replaces #1675.

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Matthew Murray (https://github.com/Matt711)

Approvers:
  - Matthew Murray (https://github.com/Matt711)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #1756
@bdice bdice mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harrism harrism harrism approved these changes

Assignees

@Matt711 Matt711

Labels

0 - Blocked Cannot progress due to external reasons improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API

Projects

RMM Project Board
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fetch runtime version with cuda-python instead of numba.

3 participants

@Matt711 @harrism @wence-