Skip to content

[BUG] Doc build failures due to cuda-python namespace rewrite #1698

Closed

Description

@wence-

Describe the bug

Recently, the low-level cuda-python bindings were reorganised (see NVIDIA/cuda-python#137). Since the documentation is not versioned, and we cross-link a reference to cudaCpuDeviceId, it no longer resolves and the doc build breaks.

We should update the reference.

Activity

  1. added
    bugSomething isn't working
    docDocumentation
    on Oct 9, 2024
  2. self-assigned this
    on Oct 9, 2024
  3. moved this from Todo to In Progress in RMM Project Boardon Oct 9, 2024
  4. added a commit that references this issue on Oct 9, 2024
    530e03a
  5. leofang commented on Oct 9, 2024

    @leofang
    Member

    Hmmm this is unexpected as we meant to keep things fully backward compatible. The old modules still exist. @wence- do you have a CI log for the doc build issue that we can take a look at?

  6. charlesbluca commented on Oct 9, 2024

    @charlesbluca
    Member

    do you have a CI log for the doc build issue that we can take a look at?

    Here's an example:

    https://github.com/rapidsai/rmm/actions/runs/11248565164/job/31274194449

    In particular the failure is

    /__w/rmm/rmm/python/rmm/docs/docstring of rmm.pylibrmm.device_buffer.DeviceBuffer.prefetch:10: WARNING: py:attr reference target not found: cuda.cudart.cudaCpuDeviceId
    
  7. wence- commented on Oct 9, 2024

    @wence-
    ContributorAuthor

    Hmmm this is unexpected as we meant to keep things fully backward compatible. The old modules still exist. @wence- do you have a CI log for the doc build issue that we can take a look at?

    Although the modules are backwards compatible, the intersphinx mapping (objects.inv) only has the new module names in it.

  8. leofang commented on Oct 9, 2024

    @leofang
    Member

    Although the modules are backwards compatible, the intersphinx mapping (objects.inv) only has the new module names in it.

    Yeah seems to be the case

    $ python -m sphinx.ext.intersphinx https://nvidia.github.io/cuda-python/objects.inv | grep cudaCpuDeviceId
        cuda.bindings.runtime.cudaCpuDeviceId                                            : module/runtime.html#cuda.bindings.runtime.cudaCpuDeviceId

    and it seems to be a known limitation of Sphinx with aliased objects (maybe sphinx-doc/sphinx#10794 & sphinx-doc/sphinx#10151 are relevant).

    We'll keep an eye on it, if it breaks too widely we'll need to figure out a workaround.

  9. moved this from In Progress to Done in RMM Project Boardon Oct 9, 2024
  10. moved this from In Progress to Done in RMM Project Boardon Oct 9, 2024
  11. added a commit that references this issue on Oct 9, 2024
    4e519bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingdocDocumentation

Type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions