Skip to content

Fix list to tuple conversion#555

Merged
rapids-bot[bot] merged 2 commits into
rapidsai:branch-0.19from
madsbk:fix_list_to_tuple_convertion
Mar 24, 2021
Merged

Fix list to tuple conversion#555
rapids-bot[bot] merged 2 commits into
rapidsai:branch-0.19from
madsbk:fix_list_to_tuple_convertion

Conversation

@madsbk

@madsbk madsbk commented Mar 23, 2021

Copy link
Copy Markdown
Member

Fixes #549 by converting received tuples to lists.

Depend on dask/distributed#4621, which fixes an unrelated bug also triggered by our explicit-comms tests.

@madsbk madsbk added 3 - Ready for Review Ready for review by team 5 - Merge After Dependencies Depends on another PR: do not merge out of order improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 23, 2021
@madsbk
madsbk requested a review from a team as a code owner March 23, 2021 14:03
@github-actions github-actions Bot added the python python code needed label Mar 23, 2021
@madsbk madsbk changed the title Fix list to tuple convertion Fix list to tuple conversion Mar 23, 2021
@madsbk
madsbk force-pushed the fix_list_to_tuple_convertion branch from 945ad87 to b833075 Compare March 23, 2021 14:07
@madsbk

madsbk commented Mar 24, 2021

Copy link
Copy Markdown
Member Author

rerun tests

@madsbk madsbk removed the 5 - Merge After Dependencies Depends on another PR: do not merge out of order label Mar 24, 2021

@pentschev pentschev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @madsbk !

@pentschev

Copy link
Copy Markdown
Member

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit 9747c96 into rapidsai:branch-0.19 Mar 24, 2021
@madsbk
madsbk deleted the fix_list_to_tuple_convertion branch April 7, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failures with explicit comms

2 participants