Added schema discovery for pg_stat_statements extension #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR. In general, the information about which schema an extension is installed in seems to be useful enough to be included the pgmetrics output. I'm thinking it might be better to collect the name of the schema also during The new query in SELECT e.name AS name, current_database(),
COALESCE(e.default_version, ''),
x.extversion,
COALESCE(e.comment, ''),
x.extnamespace::regnamespace
FROM pg_available_extensions() e(name, default_version, comment)
LEFT JOIN pg_extension x ON e.name = x.extname
WHERE x.extversion IS NOT NULL
ORDER BY name ASCWhat are your thoughts? |
Author
|
Hi I think this is a good idea, I'll try to improve my PR |
…t in a new field in pgmetrics.Extension.SchemaName
Author
|
@mdevan please, review my changes) |
Contributor
|
Thanks for the update. Couple more minor changes are required for consistency with how we add new fields and modify queries, but I think I'll do that myself after merging this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database may have a non-standard search_path (standard:
"$user", public) that does not include the public schema. In this case, you need to discovery which schema the pg_stat_statements extension is installed in and use the full name schema.pg_stat_statements in the query.