Fix target DisableNops not being passed to payload#10591
Merged
wchen-r7 merged 1 commit intorapid7:masterfrom Sep 6, 2018
Merged
Fix target DisableNops not being passed to payload#10591wchen-r7 merged 1 commit intorapid7:masterfrom
wchen-r7 merged 1 commit intorapid7:masterfrom
Conversation
Contributor
|
Seems to be ok. If I have space that's 1024 bytes, and by setting |
wchen-r7
added a commit
that referenced
this pull request
Sep 6, 2018
Contributor
Release NotesPayloads now support the DisableNops option correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DisableNopsdoesn't work in a target, butSpaceand other related options do, so there is no straightforward way to avoid NOP generation in a target with a space restriction.Please see #9892 and #9898 for context.
DisableNopsin a target withSpace(example:'Payload' => {'Space' => 4089, 'DisableNops' => true})Required by #10564. cc @wchen-r7