Use JVMS 4.2.2 "Unqualified name" definition to validate identifier#1829
Merged
raphw merged 1 commit intoraphw:masterfrom Jun 25, 2025
Merged
Use JVMS 4.2.2 "Unqualified name" definition to validate identifier#1829raphw merged 1 commit intoraphw:masterfrom
raphw merged 1 commit intoraphw:masterfrom
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Rafael,
Following our google group discussion, I managed to take some time to improve identifier name validation.
I validated the implementation check against the current OpenJDK parser code.
I created two additional methods. I hesitated to create a single method, to avoid the almost same loop in both methods. But I went for readability in this case. Let me know what you think.
Hope this helps,
Guillaume