Add findbugs hint.

raphw · raphw · commit 81065d385f23 · 2022-01-14T20:10:43.000+01:00
diff --git a/byte-buddy-dep/src/main/java/net/bytebuddy/asm/Advice.java b/byte-buddy-dep/src/main/java/net/bytebuddy/asm/Advice.java
@@ -6368,7 +6368,7 @@ protected WithPreservedArguments(TypeDescription instrumentedType,
                 }
 
                 @Override
-                @SuppressFBWarnings(value = "RC_REF_COMPARISON_BAD_PRACTICE", justification = "ASM models frames by reference comparison.")
+                @SuppressFBWarnings(value = "RC_REF_COMPARISON_BAD_PRACTICE", justification = "ASM models frames by reference identity.")
                 protected void translateFrame(MethodVisitor methodVisitor,
                                               TranslationMode translationMode,
                                               MethodDescription methodDescription,
@@ -6628,7 +6628,7 @@ public void injectStartFrame(MethodVisitor methodVisitor) {
                     /**
                      * {@inheritDoc}
                      */
-                    @SuppressFBWarnings(value = "RC_REF_COMPARISON_BAD_PRACTICE", justification = "Reference equality is required by ASM.")
+                    @SuppressFBWarnings(value = "RC_REF_COMPARISON_BAD_PRACTICE", justification = "ASM models frames by reference identity.")
                     public void translateFrame(MethodVisitor methodVisitor,
                                                int type,
                                                int localVariableLength,
diff --git a/byte-buddy-dep/src/main/java/net/bytebuddy/utility/visitor/StackAwareMethodVisitor.java b/byte-buddy-dep/src/main/java/net/bytebuddy/utility/visitor/StackAwareMethodVisitor.java
@@ -445,6 +445,7 @@ public void visitTryCatchBlock(Label start, Label end, Label handler, @MaybeNull
     }
 
     @Override
+    @SuppressFBWarnings(value = "RC_REF_COMPARISON_BAD_PRACTICE", justification = "ASM models frames by reference identity.")
     public void visitFrame(int type, int localVariableLength, @MaybeNull Object[] localVariable, int stackSize, @MaybeNull Object[] stack) {
         switch (type) {
             case Opcodes.F_SAME:

Original file line number	Diff line number	Diff line change
`@@ -445,6 +445,7 @@ public void visitTryCatchBlock(Label start, Label end, Label handler, @MaybeNull`
`445`	`445`	`}`
`446`	`446`
`447`	`447`	`@Override`
	`448`	`+ @SuppressFBWarnings(value = "RC_REF_COMPARISON_BAD_PRACTICE", justification = "ASM models frames by reference identity.")`
`448`	`449`	`public void visitFrame(int type, int localVariableLength, @MaybeNull Object[] localVariable, int stackSize, @MaybeNull Object[] stack) {`
`449`	`450`	`switch (type) {`
`450`	`451`	`case Opcodes.F_SAME:`