We've been there and done that. This will restore errors #261 #337 which are the reason why there is a direct path in require.

Can you confirm that this change fixes the "module parse failed" issue? I can't reproduce the scenario that has this issue.

cc @jayd-mh and @bplies-ATX which had the original issue, can you test if this change does not cause a regression?

@ranisalt I'm not a participant in that project anymore but I've contacted someone that is and asked if they'll check into this.
So I cannot promise if or when it'll happen. I really want to help you because you helped us, but for the moment this is the best that I can do.

@Voltra can you revert all changes except the relevant ones, which are the lines in argon2.js?

I found a way to fix Electron packaging, by adding

  externals: {
    'nock': 'commonjs nock',
    'aws-sdk': 'commonjs aws-sdk',
    'mock-aws-s3': 'commonjs mock-aws-s3',
  }

to the webpack configuration. This will mark these three dependencies to @mapbox/node-pre-gyp as externals, that is, as installed in the base system and therefore not packaged in the Electron app (as far as I understood). These are only used to download prebuilt binaries, and will not be needed in runtime.

That would allow merging this fix and keep working in Electron.

Thanks!