Repository navigation
test(prerender): add e2e coverage for notFoundBoundary on prerender routes - #438
Merged
Merged
Conversation
…outes Add a notFoundBoundary to the docs.article prerender route and verify that non-prerendered slugs in production render the custom 404 UI from the boundary rather than the generic Not Found page. This covers the interaction between the prerender stub (DataNotFoundError) and the notFoundBoundary DSL helper.
7 tasks done
ivogt
added a commit
that referenced
this pull request
Jul 4, 2026
… HITs (#669) A bake-lane loader's nested promise that settled inside the capture window was recorded as its RAW value; the HIT overlay handed that plain value to consumers whose code is an unconditional use(data.x) - React #438, root error boundary, whole page down (found live on a storefront PDP whose 165ms price fetch won the quiet window because a concurrent loader kept the Flight stream byte-active past it). - loader-snapshot.ts: settled nested promises now record behind a $rangoLoaderSettled marker; overlayLoaderContainer rehydrates them as Promise.resolve(pinned). A capture-computed holes bit on the marker picks the rehydration path (fully-pinned resolves immediately; deep holes chain on the fresh promise) so HITs never rescan the pinned subtree. The root container still unwraps (elideNested owns nested marking - no root flag). - Red->green: 7 unit regressions + /shell-cache/settled + /ppr-shell/settled e2e twins (dev + production, both apps). - guardHydrationErrors hoisted to @shared/e2e with one canonical string list (unminified #438 text + [RootErrorBoundary]); the two suite-local copies had already drifted, which is how the regression e2e passed against broken code. waitForHydration keeps the error window in scope. - parallel() DSL: dropped the inference-only TSlots generic in both type files - bare arrow slot handlers get a typed ctx (descriptor arrows still need an annotation; StaticHandlerDefinition.handler pollutes the union). - skills/ppr + parallel, loader-container-bake design doc updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notFoundBoundaryto thedocs.articleprerender route in the test appTest plan