You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Nested unnamed include() never matches: its routes answer 404 with no warning #1104
On 0.22.1, the routes of an unnamed include() that sits inside another unnamed include() are never matched. They answer 404, with no warning at build or rango generate time.
// urls.tsxinclude("/",publicPatterns),// unnamed// urls-public.tsxexportconstpublicPatterns=urls(({ include })=>[include("/",signInPatterns),// unnamed, nested: /login now answers 404]);
Giving the inner include a name, even an empty one, fixes it: include("/", signInPatterns, { name: "" }).
Expected
Nested unnamed includes match the same as one level does. If they can't, the generator or the router fails loudly and names the include.
Why it matters
The typecheck, unit tests and rango generate all passed. Only an end-to-end test that signed in caught it, after every public route of the app had gone 404.
Activity
fix(router): nested unnamed include() routes match; hidden include na…
fix(testing): dispatch matches through the route trie, as dev and pro…
fix(router): nested unnamed include() routes match; hidden include na…
fix(testing): dispatch matches through the route trie, as dev and pro…
fix(router): nested unnamed include() routes match; dispatch matches …
docs(skills): app-structure — concrete urls() layouts for SaaS, multi…
docs(skills): app-structure — concrete urls() layouts for SaaS, multi…