Skip to content

Commit d9cbaa0

Browse files
committed
Merge #1233: chore(tools): check:internals ratchet on internals coupling (S4)
2 parents 795ce3d + c65dfd0 commit d9cbaa0

6 files changed

Lines changed: 1514 additions & 0 deletions

File tree

‎.github/workflows/e2e.yml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,9 @@ jobs:
112112
- name: Check no external stores (useSyncExternalStore, store libraries, render-time store reads)
113113
run: pnpm check:no-external-store
114114

115+
- name: Check internals ratchet (derived request contexts, internal vi.mock, _rsc_ literals, browser/ imports into the server graph)
116+
run: pnpm check:internals
117+
115118
- name: Test repo check tools
116119
run: pnpm test:tools
117120

‎AGENTS.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ Contract for any coding agent in this repo (CLAUDE.md symlinks here). **Hard rul
2525
| Create, memoize or hand a promise to a Suspense boundary, emit a tree update, or touch `src/segment-system.tsx`, `src/route-content-wrapper.tsx`, `src/segment-loader-promise.ts`, `src/segment-boundary-content.ts`, `src/use-loader.tsx` | First read `packages/rangojs-router/docs/internal/suspense-contract.md`; run the `suspense-cases` and `held-boundary` suites in dev AND production, in the router test-app and cloudflare-basic, before push |
2626
| Change when a router hook's value commits, or touch a file Hard rule 10 lists | MUST follow Hard rule 10 first |
2727
| Add any e2e test | Both a dev AND a `(production)` describe (Hard rule 3 + bucketing) |
28+
| Add a derived request context, a segment-walker parameter, a store read path, a `_rsc_*` literal, an internal `vi.mock`, or a runtime `browser/` import into `server/`, `rsc/`, `router/` or `cache/` | Once its seam has landed, use it (`deriveRenderPass`, `ResolutionPass`, `readRecord`, `wire-params.ts`, the test kit). Run `pnpm check:internals`: its counts only go down, and a raise needs owner approval |
2829
| Change exports or add/remove source files | Update the Internal reference docs in the same PR |
2930
| Locate where a feature lives | Start from `docs/internal/feature-map.md` and `docs/internal/feature-file-map.md` |
3031

‎package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
"check:e2e-console-baseline": "node tools/check-e2e-console-baseline.mjs",
1919
"check:suspense-contract": "node tools/check-suspense-contract.mjs",
2020
"check:no-external-store": "node tools/check-no-external-store.mjs",
21+
"check:internals": "node tools/check-internals.mjs",
2122
"check:doc-links": "node tools/check-doc-links.mjs",
2223
"check:docs-api": "node tools/check-docs-api.mjs",
2324
"check:skills": "node tools/check-skills.mjs",

0 commit comments

Comments
 (0)