You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit a12b3e6
Browse filesBrowse the repository at this point in the historyBrowse files
test(ppr): pin the outlined-bake guarantee — ready Suspense content bakes into the shell; masked holes postpone (closes#702) (#703)
Investigation outcome (issue #702): the suspected defect does NOT exist.
Control experiments proved the capture already bakes outlined-but-ready
content through the real abort path (6.2MB prelude, postponed=null on a
bare ppr route; 6.2MB + 1.5KB postponed beside a masked slot hole), and
ready fizz work cannot lose the abort race structurally: React's
tracked-postpones pings run on scheduleMicrotask while the post-quiesce
hops and abort ride setTimeout, so every runnable task drains before the
first hop fires. A counted-abort gate would be a no-op for ready work and
would BREAK the physics-hole doctrine (parked unmasked I/O must postpone).
The original red reproducer was doctrine-inconsistent, not a bug repro:
under route-level loading(), LoaderBoundary use()es the masked loader
ABOVE the entire route subtree, so the whole body IS the hole — its 30k
rows were unreachable at capture (4.5KB prelude), not ready-but-unflushed.
React postpones whole Suspense boundaries, so bytes inside a postponed
boundary can never ride the prelude.
What this PR pins, on the reshaped /shell-cache/outlined fixture (10k-row
outlined section BESIDE a masked @outlinedBadge slot hole, never under
it):
- every outlined row lands in the stored prelude (byte-provenance via
splitPrelude, rows 0 and 9999 before the first </html>);
- the masked hole still postpones (badge fallback frozen in the prelude,
digit-anchored value only in the resumed tail, seq advances per HIT
while the prelude stays byte-identical);
- dev + production describes both run it.
Also documents the microtask-atomicity invariant on the abort hop loop in
ssr/index.tsx (comment-only src change) so a work-quiet/counted gate is
not re-attempted, and the fixture carries the doctrine clarification:
content that must bake belongs beside the hole (slot/layout chrome), not
under route-level loading().
Battery: router unit 5052; shell suites 33 dev / 34 production;
prerender-ppr 4+4 (producer B composition); cloudflare ppr battery 27
passed (3 pre-existing producer-B dev-boot flakes, untouched files);
typecheck/lint/format green.
0 commit comments