Repository navigation
Commit 2723a56
committed
fix(router): strip reserved redirect marker from stub-merge primitives (#572)
Review follow-up: the reserved x-rango-redirect-external header could still leak
on a non-3xx response when set through the stub (e.g. a stray
ctx.header("x-rango-redirect-external", "1") in middleware or a response route).
mergeResponse() strips the marker from the base response, but the stub/header-
merge primitives re-introduced it: createResponseWithMergedHeaders ->
applyStubHeaders copies ctx.res.headers, and middleware mergeResponse() merges
mergeStubHeaders/mergeReqCtxStub back in after the delete. This did not reopen the
redirect bypass (3xx still hits the guard, which strips), but it contradicted the
guarantee that the reserved header is stripped at every browser-facing exit.
Fix: applyStubHeaders, mergeStubHeaders, and mergeReqCtxStub now refuse to copy
the reserved marker (same treatment Set-Cookie already gets). The opt-in remains
the out-of-band brand; the header is never a trust signal and never leaves.
Tests (red-before-green, via the dispatch userland primitive): a marker set via
ctx.header() on a non-3xx middleware short-circuit (mergeStubHeaders), on a
response-route 200 (applyStubHeaders), and on the request-context stub through the
middleware chain (mergeReqCtxStub) are all stripped. Docs updated.
Full gate green: typecheck, test:unit:all, lint, format; e2e redirect-guard +
semantic-matrix (dev + production).1 parent 5dbe63b commit 2723a56
4 files changed
Lines changed: 79 additions & 7 deletions
File tree
- packages/rangojs-router
- docs/internal
- src
- router
- rsc
- testing/__tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
142 | 146 | | |
143 | 147 | | |
144 | 148 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
300 | 300 | | |
301 | 301 | | |
302 | 302 | | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
303 | 307 | | |
304 | 308 | | |
305 | 309 | | |
| |||
325 | 329 | | |
326 | 330 | | |
327 | 331 | | |
| 332 | + | |
| 333 | + | |
328 | 334 | | |
329 | 335 | | |
330 | 336 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
49 | 53 | | |
50 | 54 | | |
51 | 55 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
460 | 460 | | |
461 | 461 | | |
462 | 462 | | |
463 | | - | |
| 463 | + | |
464 | 464 | | |
465 | 465 | | |
466 | 466 | | |
| |||
476 | 476 | | |
477 | 477 | | |
478 | 478 | | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
479 | 537 | | |
480 | 538 | | |
481 | 539 | | |
| |||
0 commit comments