Conversation
badasukerubin
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #261 +/- ##
==========================================
- Coverage 97.65% 97.05% -0.60%
==========================================
Files 6 6
Lines 128 136 +8
==========================================
+ Hits 125 132 +7
- Misses 3 4 +1
🚀 New features to boost your workflow:
|
ramsey
changed the title
ramsey
approved these changes
Mar 5, 2025
Owner
ramsey
left a comment
ramsey
left a comment
There was a problem hiding this comment.
Thank you for contributing, and sorry for taking so long to review this.
I've made a slight change, using composer-filename instead of custom-composer-filename and setting its default value to "composer". I hope this is okay with you.
|
I believe this change broke workflows that used the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #258 .
This adds a new
composer-filenameoption to the action, allowing for adding a custom composer filename, which can be helpful for using composer based on different environments.See: https://getcomposer.org/doc/03-cli.md#composer
Fixes #258.
Motivation and context
See: #258
How has this been tested?
Both unit tests as well as integration tests are included with the PR.
Types of changes
PR checklist