upgrade nunjucks and fix template#231
upgrade nunjucks and fix template#231kevinrenskers merged 1 commit intoraml2html:developfrom chulkilee:update-nunjucks
Conversation
|
Thanks, I'll be reviewing this shortly and should then make it into raml2html 2.5.0. |
|
I'd love to upgrade nunjucks and nunjucks-markdown, but this will break every customized template because of this change in whitespace behavior. Maybe we should fork nunjucks-markdown and have it work as before? Maybe it's as simple as taking version 1 of that library, update its peer dependency and done. In any case, if we're going with a version of nunjucks-markdown that changes this whitespace behavior then this needs to wait for raml2html 3.0 because it's a major breaking change. |
- old version of nunjucks depends on old version of fsevents via chokidar, which does not work on node 6.x. See fsevents/fsevents#128 - nunjucks-markdown expect blocks at the same level with {% markdown %} tag. So fix the template.
|
Agreed that it should come with major version bump - do you have a roadmap for raml2html 3? e.g. will raml1.0 branch become raml2html3? Anyway, updated the branch to fix conflicts. |
|
raml2html 3.0 will include RAML 1.0 support and a brand new template. |
2 participants
chokidar, which does not work on node 6.x. See
Don't use deprecated v8::Template::Set(). fsevents/fsevents#128
tag. So fix the template.