Fix missing Makefile.in in Ruby 2.7#161
Closed
qnighy wants to merge 1 commit intorake-compiler:masterfrom
Closed
Conversation
Starting from Ruby 2.7.0.preview2 (ruby/ruby@c7477c3), Makefile.in is no longer in the root. Instead it has been moved under ./template/. This patch fixes the problem by allowing makefiles in both places.
Member
|
Thanks for your pull request. |
Contributor
Author
|
Confirmed to work. Thanks! |
Member
|
@knu Any chance to release 1.0.9? I'm just preparing rake-compiler-dock for ruby-2.7 and this patch is required. |
Member
|
Ah, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from Ruby 2.7.0.preview2 (ruby/ruby@c7477c3), Makefile.in is no
longer in the root. Instead it has been moved under ./template/.
This patch fixes the problem by allowing makefiles in both places.
Note that this doesn't fix all the problems building Ruby 2.7. It fails to generate
builtin_binary.incbut I'm not sure the proper way to fix it.