Move RecoverKeysOnlyFilter into RecoverDataBaseFile

achow101 · achow101 · commit ea337f2d0318 · 2020-05-25T12:59:29.000-04:00
diff --git a/src/wallet/salvage.cpp b/src/wallet/salvage.cpp
@@ -15,7 +15,7 @@ static const char *HEADER_END = "HEADER=END";
 static const char *DATA_END = "DATA=END";
 typedef std::pair<std::vector<unsigned char>, std::vector<unsigned char> > KeyValPair;
 
-bool RecoverDatabaseFile(const fs::path& file_path, void *callbackDataIn, bool (*recoverKVcallback)(void* callbackData, CDataStream ssKey, CDataStream ssValue), std::string& newFilename)
+bool RecoverDatabaseFile(const fs::path& file_path)
 {
     std::string filename;
     std::shared_ptr<BerkeleyEnvironment> env = GetWalletEnv(file_path, filename);
@@ -28,7 +28,7 @@ bool RecoverDatabaseFile(const fs::path& file_path, void *callbackDataIn, bool (
     // Set -rescan so any missing transactions will be
     // found.
     int64_t now = GetTime();
-    newFilename = strprintf("%s.%d.bak", filename, now);
+    std::string newFilename = strprintf("%s.%d.bak", filename, now);
 
     int result = env->dbenv->dbrename(nullptr, filename.c_str(), nullptr,
                                        newFilename.c_str(), DB_AUTO_COMMIT);
@@ -116,14 +116,26 @@ bool RecoverDatabaseFile(const fs::path& file_path, void *callbackDataIn, bool (
     }
 
     DbTxn* ptxn = env->TxnBegin();
+    CWallet dummyWallet(nullptr, WalletLocation(), WalletDatabase::CreateDummy());
     for (KeyValPair& row : salvagedData)
     {
-        if (recoverKVcallback)
+        /* Filter for only private key type KV pairs to be added to the salvaged wallet */
+        CDataStream ssKey(row.first, SER_DISK, CLIENT_VERSION);
+        CDataStream ssValue(row.second, SER_DISK, CLIENT_VERSION);
+        std::string strType, strErr;
+        bool fReadOK;
         {
-            CDataStream ssKey(row.first, SER_DISK, CLIENT_VERSION);
-            CDataStream ssValue(row.second, SER_DISK, CLIENT_VERSION);
-            if (!(*recoverKVcallback)(callbackDataIn, ssKey, ssValue))
-                continue;
+            // Required in LoadKeyMetadata():
+            LOCK(dummyWallet.cs_wallet);
+            fReadOK = ReadKeyValue(&dummyWallet, ssKey, ssValue, strType, strErr);
+        }
+        if (!WalletBatch::IsKeyType(strType) && strType != DBKeys::HDCHAIN) {
+            continue;
+        }
+        if (!fReadOK)
+        {
+            LogPrintf("WARNING: WalletBatch::Recover skipping %s: %s\n", strType, strErr);
+            continue;
         }
         Dbt datKey(&row.first[0], row.first.size());
         Dbt datValue(&row.second[0], row.second.size());
@@ -136,25 +148,3 @@ bool RecoverDatabaseFile(const fs::path& file_path, void *callbackDataIn, bool (
 
     return fSuccess;
 }
-
-bool RecoverKeysOnlyFilter(void *callbackData, CDataStream ssKey, CDataStream ssValue)
-{
-    CWallet *dummyWallet = reinterpret_cast<CWallet*>(callbackData);
-    std::string strType, strErr;
-    bool fReadOK;
-    {
-        // Required in LoadKeyMetadata():
-        LOCK(dummyWallet->cs_wallet);
-        fReadOK = ReadKeyValue(dummyWallet, ssKey, ssValue, strType, strErr);
-    }
-    if (!WalletBatch::IsKeyType(strType) && strType != DBKeys::HDCHAIN) {
-        return false;
-    }
-    if (!fReadOK)
-    {
-        LogPrintf("WARNING: WalletBatch::Recover skipping %s: %s\n", strType, strErr);
-        return false;
-    }
-
-    return true;
-}
diff --git a/src/wallet/salvage.h b/src/wallet/salvage.h
@@ -9,9 +9,6 @@
 #include <fs.h>
 #include <streams.h>
 
-bool RecoverDatabaseFile(const fs::path& file_path, void *callbackDataIn, bool (*recoverKVcallback)(void* callbackData, CDataStream ssKey, CDataStream ssValue), std::string& out_backup_filename);
-
-/* Recover filter (used as callback), will only let keys (cryptographical keys) as KV/key-type pass through */
-bool RecoverKeysOnlyFilter(void *callbackData, CDataStream ssKey, CDataStream ssValue);
+bool RecoverDatabaseFile(const fs::path& file_path);
 
 #endif // BITCOIN_WALLET_SALVAGE_H
diff --git a/src/wallet/wallettool.cpp b/src/wallet/wallettool.cpp
@@ -122,9 +122,7 @@ static bool SalvageWallet(const fs::path& path)
     }
 
     // Perform the recovery
-    CWallet dummy_wallet(nullptr, WalletLocation(), WalletDatabase::CreateDummy());
-    std::string backup_filename;
-    return RecoverDatabaseFile(path, (void*)&dummy_wallet, RecoverKeysOnlyFilter, backup_filename);
+    return RecoverDatabaseFile(path);
 }
 
 bool ExecuteWalletToolFunc(const std::string& command, const std::string& name)

Original file line number	Diff line number	Diff line change
`@@ -122,9 +122,7 @@ static bool SalvageWallet(const fs::path& path)`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`// Perform the recovery`
`125`		`- CWallet dummy_wallet(nullptr, WalletLocation(), WalletDatabase::CreateDummy());`
`126`		`- std::string backup_filename;`
`127`		`- return RecoverDatabaseFile(path, (void*)&dummy_wallet, RecoverKeysOnlyFilter, backup_filename);`
	`125`	`+ return RecoverDatabaseFile(path);`
`128`	`126`	`}`
`129`	`127`
`130`	`128`	`bool ExecuteWalletToolFunc(const std::string& command, const std::string& name)`