Skip to content

Fix swap max ux issues - #563

Merged
brunobar79 merged 5 commits into
developfrom
@bruno/swap-max-ux-issues
Apr 17, 2020
Merged

brunobar79 merged 5 commits into
developfrom
@bruno/swap-max-ux-issues

Conversation

@brunobar79

Copy link
Copy Markdown
Contributor

Fixes RAI-496

@linear

linear Bot commented Apr 16, 2020

Copy link
Copy Markdown

@brunobar79
brunobar79 force-pushed the @bruno/swap-max-ux-issues branch from 1cade0e to b555b8e Compare April 17, 2020 03:06

@christianbaroni christianbaroni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯💯💯
works great

Comment thread src/screens/ExchangeModal.js Resolved
@brunobar79
brunobar79 force-pushed the @bruno/swap-max-ux-issues branch from 5ba7811 to 1edf224 Compare April 17, 2020 09:35
Comment thread src/raps/actions/unlock.js Resolved
Comment thread src/screens/ExchangeModal.js Resolved
Comment thread src/screens/ExchangeModal.js Resolved
@brunobar79
brunobar79 force-pushed the @bruno/swap-max-ux-issues branch from 19edb3d to fae51ce Compare April 17, 2020 17:58
@brunobar79
brunobar79 merged commit 13f27f2 into develop Apr 17, 2020
@brunobar79
brunobar79 deleted the @bruno/swap-max-ux-issues branch April 17, 2020 17:58
olerass added a commit that referenced this pull request Apr 22, 2026
The `Ensure Simulator is fully booted` step in `ios-e2e.yml` polls `xcrun simctl list | grep "Booted"` with a 120-second timeout. The `simulator-action` that creates the simulator already supports a `wait_for_boot: true` input that uses Apple's `simctl bootstatus` internally, which is the supported mechanism for detecting simulator readiness. The custom loop was added in #6713 (Aug 2025) during the GH Actions migration with no documented rationale; presumably the action's native wait was simply overlooked at the time.

We noticed the grep-based detection is fragile while working on the iOS 26 SDK migration. An iOS 26.4 simulator booted in ~36 seconds, yet our custom loop timed out at 120s because the `grep 'Booted'` pattern didn't match reliably during the boot transition. Swapping to the action's native wait fixed it cleanly in that context.

This change backports the combined swap to develop's current iPhone 16 / iOS 18.5 setup. Behavior should be equivalent on green runs and more robust on slow boots.

@janicduplessis pointed out on this PR that the built-in wait has historically been flaky: `simctl bootstatus` sometimes returns while the simulator isn't actually ready, or hangs outright. We actually observed that hang pattern on one shard here. To combat this the change also bumps the simulator-action from v4 to v5, which addresses this exact class of flake. v5 ships `boot_timeout_seconds: 360` and `boot_retries: 2` as defaults (see [#563](futureware-tech/simulator-action#563)), so a hung `bootstatus` call now bails after 6 minutes and retries up to twice before failing the step. No explicit config needed on our side.

Ref FEPLAT-81.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants