Use window.Turbo.fetch if available for turbo-stream requests#74
Merged
marcelolx merged 2 commits intorails:mainfrom Aug 30, 2024
Merged
Use window.Turbo.fetch if available for turbo-stream requests#74marcelolx merged 2 commits intorails:mainfrom
marcelolx merged 2 commits intorails:mainfrom
Conversation
Contributor
Author
|
Let me know if you need any further testing done, or have any concerns with this change. I've been using it in development and it's working really well. Much cleaner than fake-clicking hidden submit buttons ;) |
Contributor
Author
|
Hi @marcelolx, just wondering if you'd be able to make a new release with this change in it? :) |
Collaborator
Collaborator
|
@brendon Done |
Contributor
Author
|
Thanks @marcelolx :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks for
window.Turboand if theresponseKindisturbo-streamand if both are true thenrequest.jswill usewindow.Turbo.fetchin order to appendX-Turbo-Request-Idto the request headers.The tests don't actually bring in Turbo just as the existing tests don't.
window.Turbo.fetchas at time of writing:https://github.com/hotwired/turbo/blob/4d65288e913d5a5428e290781313c7909763b133/src/http/fetch.js
Closes: #73