Closed
Conversation
Adds an add_index override to the Postgresql and MySQL adapters for supporting custom index types.
Contributor
|
+1 |
Member
Contributor
|
👍 for |
Member
|
Yes. |
Member
|
@techpeace would you mind updating this PR to use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an updated version of #6101. I just squashed it and added a CHANGELOG entry, as per @steveklabnik's request. I also had to make a small tweak, but it was a one-line change. The majority of the work is still @MSNexploder's.
The original pull request adds a
:typeoption toadd_indexfor the Postgresql and MySQL adapters that allows custom index type support:@jeremy noted that perhaps this should be a
:usingoption, since that would better reflect the SQL syntax. I'd be happy to make that change, if that sounds better.