Support Different Engines for Different Tables; Support MyISAM FULLTEXT indexes#8239
Closed
kenmazaika wants to merge 1 commit intorails:masterfrom
Closed
Support Different Engines for Different Tables; Support MyISAM FULLTEXT indexes#8239kenmazaika wants to merge 1 commit intorails:masterfrom
kenmazaika wants to merge 1 commit intorails:masterfrom
Conversation
…port for MyISAM fulltext indexes in migrations, and schema.rb.
Member
There was a problem hiding this comment.
Is better to add a :fulltext attribute
Member
There was a problem hiding this comment.
I think is better to leave this as :options since we have the SPACIAL indexes too.
Member
|
We will need tests. Also I would only add support for the full text indexes in this pull request and open a new one to add support to MyISAM |
Member
|
Also this is related with #6101 |
Member
Member
|
Thank you so much for the pull request |
Contributor
Author
|
@rafaelfranca thanks for reviewing this so quickly. Closing this pull request now, I'll open 2 separate ones with the changes you suggest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for different MySQL engines for different tables; Add support for MyISAM fulltext indexes in migrations, and schema.rb.
In a project I was working on we wanted to use MyISAM fulltext indexes for a single table, but continue to use InnoDB for the remaining tables. This patch adds support for that. Without this patch it's impossible to use the full-text search query syntax, because in the test database it would continue to use the default engine for all, and not add the fulltext option to the index that is create (just a standard key would be created, which isn't what we needed).
Sources:
Integrated: multiple engine support from this gist