Preserve sub-second precision when subtracting a DateTime from a Time - #58213
Merged
Conversation
Time - DateTime converted both sides via to_f, so microsecond-level DateTime values lost precision. Compute the difference from exact rational timestamps instead, matching Time.at(DateTime) and ActiveSupport::TimeWithZone - DateTime.
Saidbek
force-pushed
the
fix/time-minus-datetime-precision
branch
from
July 22, 2026 19:30
d477364 to
4d24a25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Time - DateTime(ActiveSupport layers this on top ofTime#-) converted both sides viaFloat(to_f). AFloatcannot represent every microsecond exactly, so the resulting difference was wrong for roughly half of all sub-secondDateTimevalues.Before / After
Whole-second differences are unchanged (
Time.utc(2000, 1, 2) - DateTime.civil(2000, 1, 1)is still86400).Why this is correct
Time - DateTimein line with the sibling paths that already use exact rational timestamps:Time.at(DateTime)(Preserve sub-second precision when coercing aDateTimeinTime.at#58085) andActiveSupport::TimeWithZone - DateTime(viagetutc).DateTimeisdatetime.to_i + datetime.sec_fraction; subtracting that fromtime.to_rpreserves every microsecond.