Make lint optional, so we can pass invalid host name.#54613
Merged
byroot merged 1 commit intorails:mainfrom Feb 25, 2025
Merged
Make lint optional, so we can pass invalid host name.#54613byroot merged 1 commit intorails:mainfrom
byroot merged 1 commit intorails:mainfrom
Conversation
ioquatix
force-pushed
the
rack-lint-compatibility
branch
from
e1e1188 to
0108ccf
Compare
byroot
added a commit
that referenced
this pull request
Feb 25, 2025
Make lint optional, so we can pass invalid host name.
dentarg
added a commit
to dentarg/sinatra
that referenced
this pull request
Mar 16, 2025
dentarg
added a commit
to sinatra/sinatra
that referenced
this pull request
Mar 16, 2025
Due to better validation in Rack: rack/rack#2298 See also - rack/rack#2295 - rails/rails#54613
skipkayhil
pushed a commit
that referenced
this pull request
Sep 18, 2025
Make lint optional, so we can pass invalid host name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See rack/rack#2298 for context. If you are passing an invalid host name, as this test is doing,
Rack::Lintwill soon start raising an error. Allow bypassingRack::Lintso that we can pass the invalid host name in the test.