backport #51592 to 7-1-stable allowing sqlite3 v2 #51636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit fd1c635)
flavorjones
changed the title
flavorjones
added a commit
to active-hash/active_hash
that referenced
this pull request
Apr 24, 2024
because the Rails adapter requires `~> 1.4` through v7.1.3.2 we can loosen this for later versions of Rails that contain rails/rails#51592 and any future releases of 7.1 that contain rails/rails#51636
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
May 1, 2024
tagliala
added a commit
to activeadmin/demo.activeadmin.info
that referenced
this pull request
May 1, 2024
Also disallow sqlite3 >= 2.0 waiting for rails/rails#51636
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
May 1, 2024
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
May 1, 2024
tagliala
added a commit
to activeadmin/activeadmin
that referenced
this pull request
May 2, 2024
tagliala
added a commit
to activeadmin/demo.activeadmin.info
that referenced
this pull request
May 2, 2024
Also disallow sqlite3 >= 2.0 waiting for rails/rails#51636
tagliala
added a commit
to activeadmin/demo.activeadmin.info
that referenced
this pull request
May 2, 2024
Also disallow sqlite3 >= 2.0 waiting for rails/rails#51636
varyonic
referenced
this pull request
in activeadmin-rails/activeadmin-rails
May 8, 2024
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
Aug 23, 2024
Relax sqlite3 constraints because rails/rails#51636 is included in the latest 7.1.4 release
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
Aug 23, 2024
Relax sqlite3 version constraint because rails/rails#51636 is included in the latest 7.1.4 release
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
Aug 23, 2024
Relax sqlite3 version constraint because rails/rails#51636 is included in the latest 7.1.4 release
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
Aug 23, 2024
Relax sqlite3 version constraint because rails/rails#51636 is included in the latest 7.1.4 release
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
Aug 23, 2024
Relax sqlite3 version constraint because rails/rails#51636 is included in the latest 7.1.4 release
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
Aug 24, 2024
Relax sqlite3 version constraint because rails/rails#51636 is included in the latest 7.1.4 release
tagliala
added a commit
to activeadmin/activeadmin
that referenced
this pull request
Aug 24, 2024
Relax sqlite3 version constraint because rails/rails#51636 is included in the latest 7.1.4 release
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
Aug 24, 2024
Relax sqlite3 version constraint because rails/rails#51636 is included in the latest 7.1.4 release
tagliala
added a commit
to tagliala/activeadmin
that referenced
this pull request
Aug 24, 2024
Relax sqlite3 version constraint because rails/rails#51636 is included in the latest 7.1.4 release
tagliala
added a commit
to activeadmin/activeadmin
that referenced
this pull request
Aug 24, 2024
* Update dependencies Relax sqlite3 version constraint because rails/rails#51636 is included in the latest 7.1.4 release * Fix bug report template and update to Rails 7.2 Current bug report template does not work because sqlite3 2.x is not compatible with Rails 7.0.x. This commit also: - Test bug report template against Ruby 3.3 - Set config.eager_load to avoid a warning on stdout: ``` config.eager_load is set to nil. Please update your config/environments/*.rb files accordingly: ``` - Default to `3-0-stable` branch when `ACTIVE_ADMIN_PATH` is not specified - Add `force_ruby_platform` to `sqlite3` for uniformity with `master` branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
The sqlite3 gem released v2.0 and
mainhas been updated to allow usage of it in #51592.However, speaking as a co-maintainer of sqlite3, we are getting issues from Rails users who can't upgrade to it (e.g. sparklemotion/sqlite3-ruby#529).
So I'm opening this issue to suggest that it be backported to 7-1-stable for inclusion in a future patch release.
Detail
Cherry-pick of fd1c635
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]Tests are added or updated if you fix a bug or add a feature.