dep: allow sqlite3 gem to float to version 2 #51592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-dep-let-sqlite3-float-to-2.0
branch
2 times, most recently
from
a309e0e to
ac221c6
Compare
4 tasks
Member
Author
|
The failing test seems unrelated to this change. |
Member
|
Thanks for the update. IMO, it requires a changelog entry. |
byroot
force-pushed
the
flavorjones-dep-let-sqlite3-float-to-2.0
branch
from
ac221c6 to
fd1c635
Compare
Member
Author
|
@byroot Thanks for adding the changelog entry! |
This was referenced Apr 22, 2024
rafaelfranca
added a commit
that referenced
this pull request
Apr 22, 2024
…35d-to-7-1 backport #51592 to 7-1-stable allowing sqlite3 v2
flavorjones
added a commit
to active-hash/active_hash
that referenced
this pull request
Apr 24, 2024
because the Rails adapter requires `~> 1.4` through v7.1.3.2 we can loosen this for later versions of Rails that contain rails/rails#51592 and any future releases of 7.1 that contain rails/rails#51636
strzibny
pushed a commit
to wmlele/devise-otp
that referenced
this pull request
May 18, 2024
* pin sqlite3 to "~> 1.4" (needed for ActiveRecord adapter for now; cf. rails/rails#51592); * remove Ruby 2.7 and 3.0 from CI workflow (EOL); --------- Co-authored-by: Laney Stroup <[email protected]>
alimi
pushed a commit
to 1debit/rails-properties
that referenced
this pull request
May 29, 2024
* Starting in Rails 6, ActiveRecord's Sqlite adapter restricted the
sqlite3 gem version to ~> 1.4. This is still true in Rails 7.1. See
rails/rails#35844.
* Use the same restriction here to ensure a compatible sqlite3 version
is installed for the dev and test.
* The version restriction has been relaxed on Rails edge but it hasn't
landed in a released Rails version yet. See
rails/rails#51592.
This was referenced May 30, 2024
|
Hi, do we know in which version this is going to be released ? I waited for the next patch version (7.1.3.4) but it doesn't seem to be present yet. Thanks ! |
Member
Author
|
@jarthod Looks like this change made it into 7.1.3.3 according to the git log. What are you seeing that is preventing you from updating sqlite3? |
Member
|
I believe it will be in |
Member
Author
|
Ah, thanks for correcting me. |
|
@flavorjones @skipkayhil thank you both ! I saw it in the 7.1 changelog but without any version so it's hard to guess if it's gonna be in the next patch or minor. :) |
Member
FYI, If it's at the top of the changelog and there is no version heading that means it's unreleased |
rameziophobia
added a commit
to shakacode/react_on_rails_pro
that referenced
this pull request
Jun 30, 2024
fix: "can't activate sqlite3 (~> 1.4), already activated sqlite3-2.0.2-arm64-darwin" until this is released rails/rails#51592
jbennett
added a commit
to jbennett/money-rails
that referenced
this pull request
Jul 4, 2024
maxkadel
added a commit
to pulibrary/health-monitor-rails
that referenced
this pull request
Jul 25, 2024
- Pinning to sqlite3 ~> 1.3 until the fix for this issue is released - rails/rails#51592 (should be in 7.1.4) - Update gemfiles using Appraisal
maxkadel
added a commit
to pulibrary/health-monitor-rails
that referenced
this pull request
Jul 25, 2024
- Pinning to sqlite3 ~> 1.3 until the fix for this issue is released - rails/rails#51592 (should be in 7.1.4) - Update gemfiles using Appraisal
maxkadel
added a commit
to pulibrary/health-monitor-rails
that referenced
this pull request
Jul 25, 2024
Get tests passing locally - Pinning to sqlite3 ~> 1.3 until the fix for this issue is released - rails/rails#51592 (should be in 7.1.4) - Update gemfiles using Appraisal Add development info to readme
maxkadel
added a commit
to pulibrary/health-monitor-rails
that referenced
this pull request
Jul 26, 2024
Get tests passing locally - Pinning to sqlite3 ~> 1.3 until the fix for this issue is released - rails/rails#51592 (should be in 7.1.4) - Update gemfiles using Appraisal Add development info to readme
GabrielNagy
added a commit
to GabrielNagy/enummer
that referenced
this pull request
Aug 7, 2024
The ActiveRecord sqlite3 adapter is pinned to '~> 1.4'. A change to
relax this dependency was merged[1] but it didn't get released yet.
Until then, pin the sqlite3 dependency to avoid errors such as the
following:
Gem::LoadError: can't activate sqlite3 (~> 1.4), already activated sqlite3-2.0.3-x86_64-linux-gnu.
[1] rails/rails#51592
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
sqlite3 version v2.0.0 was just released, and has been tested against Rails. This PR will allow the sqlite3 version to float where previously it was pinned to
~> 1.4.Detail
>= 1.4from~> 1.4.Gemfileto sqlite>= 1.6.6andGemfile.lockto sqlite3 v2.0.0Additional information
The sqlite3 gem has automated integrations tests with Rails:
https://github.com/sparklemotion/sqlite3-ruby/actions/workflows/downstream.yml
Earlier today #51591 was also created in response to the 2.0.0 release.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]Tests are added or updated if you fix a bug or add a feature.CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.