Conditionally skip test job in ci.yml#51289
Merged
rafaelfranca merged 2 commits intorails:mainfrom Mar 25, 2024
Merged
Conversation
skipkayhil
reviewed
Mar 10, 2024
railties/lib/rails/generators/rails/app/templates/github/ci.yml.tt
Outdated
Show resolved
Hide resolved
railties/lib/rails/generators/rails/app/templates/github/ci.yml.tt
Outdated
Show resolved
Hide resolved
stevepolitodesign
force-pushed
the
modify-ci-template
branch
2 times, most recently
from
7d513cd to
571bea2
Compare
Skip generating a `test` job in ci.yml when a new application is generated with the `--skip-test` option.
stevepolitodesign
force-pushed
the
modify-ci-template
branch
from
571bea2 to
7118533
Compare
Member
|
(I put this on the wrong milestone, this file doesn't exist in 7.1 😅) |
fractaledmind
pushed a commit
to fractaledmind/rails
that referenced
this pull request
May 13, 2024
Skip generating a `test` job in ci.yml when a new application is generated with the `--skip-test` option. Co-authored-by: Rafael Mendonça França <[email protected]>
xjunior
pushed a commit
to xjunior/rails
that referenced
this pull request
Jun 9, 2024
Skip generating a `test` job in ci.yml when a new application is generated with the `--skip-test` option. Co-authored-by: Rafael Mendonça França <[email protected]>
HeyNonster
pushed a commit
to HeyNonster/rails
that referenced
this pull request
Jun 12, 2024
Skip generating a `test` job in ci.yml when a new application is generated with the `--skip-test` option. Co-authored-by: Rafael Mendonça França <[email protected]>
yoones
pushed a commit
to yoones/rails
that referenced
this pull request
Mar 6, 2025
Skip generating a `test` job in ci.yml when a new application is generated with the `--skip-test` option. Co-authored-by: Rafael Mendonça França <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
It's common to build new apps with
--skip-test. When this is done, CI will raise the following error:Detail
Skips the
testjob when a new application is generated with the--skip-testoption.Additional information
Uses prior art to determine if
options[:skip_test]was set.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]