Support validation for old Enum API#50333
Closed
skipkayhil wants to merge 1 commit intorails:mainfrom
Closed
Conversation
The new, symbol, `#enum` API recently [gained][1] support for a new `validate` option which replaces `ArgumentErrors` with Active Model validation errors. This commit adds `_validate` to the old, keyword argument, `#enum` API to keep the two APIs in sync. [1]: 7c65a4b
Member
|
This makes sense to me to keep API's consistent. |
Member
Author
I think deprecating makes sense, the underscored options are definitely less user friendly and it seems really easy for the two sets of options to go out of sync. (In that case, we probably don't need this PR as the recommendation would be to just migrate to the new syntax) |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
The new, symbol,
#enumAPI recently gained support for a newvalidateoption which replacesArgumentErrorswith Active Model validation errors.Detail
This commit adds
_validateto the old, keyword argument,#enumAPI to keep the two APIs in sync.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]