Skip to content

Comments

Use storage/ instead of db/ for sqlite3 db files#46699

Merged
dhh merged 9 commits intomainfrom
store-sqlite-dbs-in-storage
Dec 12, 2022
Merged

Use storage/ instead of db/ for sqlite3 db files#46699
dhh merged 9 commits intomainfrom
store-sqlite-dbs-in-storage

Conversation

@dhh
Copy link
Member

@dhh dhh commented Dec 10, 2022

The directory db/ should be for configuration only, not data. This will make it easier to mount a single data volume into a container for testing, development, and even sqlite3 in production.

db/ should be for configuration only, not data. This will make it easier to mount a single volume into a container for testing, development, and even sqlite3 in production.
@jonathanhefner
Copy link
Member

Also need to update these lines:

assert_match(/database: db\/development.sqlite3\nCurrent version: #{primary_version}/, output)
assert_match(/database: db\/development_animals.sqlite3\nCurrent version: #{animals_version}/, output)

to fix https://buildkite.com/rails/rails/builds/91579#0184fd10-9a27-4127-abee-48906413ffd3/1213-1223

@dhh dhh merged commit d18fc32 into main Dec 12, 2022
@dhh dhh deleted the store-sqlite-dbs-in-storage branch December 12, 2022 07:32
ghiculescu added a commit to ghiculescu/rails that referenced this pull request Dec 12, 2022
varyonic added a commit to activeadmin-rails/activeadmin-rails that referenced this pull request Oct 31, 2023
varyonic added a commit to activeadmin-rails/activeadmin-rails that referenced this pull request Nov 8, 2023
* rails-7.1:
  Rails 7.1 no longer populates redirect body (rails/rails#44554).
  Calling silence on ActiveSupport::Deprecation is deprecated and will be removed from Rails (use Rails.application.deprecators.silence instead)
  Deprecator setting has been deprecated.
  run db:drop, db:create and db:migrate in a separate commands (probably due to rails/rails#49349)
  Override and revert rails/rails#46699 for now, move test database from /storage back to /db
  Rails 7.1 replaces config.cache_classes with config.enable_reloading in template environment/test.rb
  Add Rails 7.1 test gem file.
  to_default_s is deprecated and will be removed from Rails 7.2 (use to_s instead)
  ActionView::OutputBuffer refactored by rails/rails#45614 (Rails 7.1)
  See rails/rails#36020
rossta added a commit to joyofrails/joyofrails.com that referenced this pull request Dec 31, 2023
Makes consistent with the new Rails default for sqlite3 db files:

rails/rails#46699
tnir added a commit to tnir/guides.railsgirls.com that referenced this pull request Jun 8, 2024
In Rails 7.1, the database filename for SQLite3 was changed:
see rails/rails#46699

Signed-off-by: Takuya Noguchi <[email protected]>
tnir added a commit to tnir/guides.railsgirls.com that referenced this pull request Jun 10, 2024
In Rails 7.1, the database filename for SQLite3 was changed:
see rails/rails#46699

Co-authored-by: りさ <[email protected]>
Signed-off-by: Takuya Noguchi <[email protected]>
tnir added a commit to tnir/railsgirls.jp that referenced this pull request Jun 11, 2024
In Rails 7.1, the database filename for SQLite3 was changed:
see rails/rails#46699

Upstream: railsgirls/guides.railsgirls.com#578

Co-authored-by: りさ <[email protected]>
Signed-off-by: Takuya Noguchi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants