Correctly parse complex check constraint expressions for PostgreSQL#43963
Merged
kamipo merged 1 commit intorails:mainfrom Dec 22, 2021
Merged
Conversation
fatkodima
force-pushed
the
fix-postgres-check-constraint-expression
branch
2 times, most recently
from
9f89b48 to
5c9a541
Compare
fatkodima
force-pushed
the
fix-postgres-check-constraint-expression
branch
from
5c9a541 to
9f0f286
Compare
kamipo
added a commit
that referenced
this pull request
Dec 22, 2021
…t-expression Correctly parse complex check constraint expressions for PostgreSQL
|
Nice fix, just noticed this bug and was perplexed for a while. Would it make sense to backport this to 6-1-stable? |
CGA1123
pushed a commit
to CGA1123/rails
that referenced
this pull request
Jul 31, 2023
…traint-expression Correctly parse complex check constraint expressions for PostgreSQL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postgres "arbitrarily" adds additional parentheses to check constraint definitions when retrieving from
pg_constraintsystem table. It can be surrounded by 2 pairs of them, or by 1.But
pg_get_constraintdefsupports additional parameter (for pretty printing) which removes them when not needed and the check constraint definiton is always looks likeCHECK (<actual definition>).Closes #43823