Add support for NOT VALID check constraints in PostgreSQL#40192
Merged
eugeneius merged 1 commit intorails:masterfrom Sep 8, 2020
Merged
Add support for NOT VALID check constraints in PostgreSQL#40192eugeneius merged 1 commit intorails:masterfrom
NOT VALID check constraints in PostgreSQL#40192eugeneius merged 1 commit intorails:masterfrom
Conversation
eugeneius
reviewed
Sep 7, 2020
activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
Outdated
Show resolved
Hide resolved
activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb
Outdated
Show resolved
Hide resolved
activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb
Outdated
Show resolved
Hide resolved
Active Record already supports adding `NOT VALID` foreign key constraints in PostgreSQL, but back in rails#31323 when check constraint support was initially added, the ability to add a check constraint and validate it separately was not included. This adds that functionality!
agrobbin
force-pushed
the
postgresql-not-valid-check-constraint
branch
from
d07f05e to
368da3e
Compare
Contributor
Author
|
Thanks so much for the quick review + merge here @eugeneius! Excited to see this in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Active Record already supports adding
NOT VALIDforeign key constraints in PostgreSQL, but back in #31323 when check constraint support was initially added, the ability to add a check constraint and validate it separately was not included. This adds that functionality!