Deprecate connection_config#38005
Merged
eileencodes merged 1 commit intorails:masterfrom Dec 17, 2019
Merged
Conversation
The `connection_config` method returns a `Hash`, but since we're moving toward a place where we're using `DatabaseConfiguration::DatabaseConfig` objects everywhere, we're introducing a new method here to replace it called `connection_db_config`. Co-authored-by: eileencodes <[email protected]>
eileencodes
added a commit
to seejohnrun/rails
that referenced
this pull request
Dec 18, 2019
We missed these in rails#38005 because deprecation warnings are silently swallowed by these tests. Co-authored-by: John Crepezzi <[email protected]>
jasonrudolph
added a commit
to jasonrudolph/scout_apm_ruby
that referenced
this pull request
Dec 19, 2020
Prior to this change, the first interaction with the database would emit the following deprecation warning with Rails 6.1: > DEPRECATION WARNING: connection_config is deprecated and will be removed from Rails 6.2 (Use connection_db_config instead) For more info, see rails/rails#38005 which introduced the deprecation.
This was referenced Dec 28, 2020
cschneid
pushed a commit
to scoutapp/scout_apm_ruby
that referenced
this pull request
May 22, 2021
Prior to this change, the first interaction with the database would emit the following deprecation warning with Rails 6.1: > DEPRECATION WARNING: connection_config is deprecated and will be removed from Rails 6.2 (Use connection_db_config instead) For more info, see rails/rails#38005 which introduced the deprecation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
connection_configmethod returns aHash, but since we're movingtoward a place where we're using
DatabaseConfiguration::DatabaseConfigobjects everywhere, we're introducing a new method here to replace it
called
connection_db_config.Co-authored-by: eileencodes [email protected]