Update MySQL server version and character set in Rails Guide [skip ci]#33929
Merged
kamipo merged 1 commit intorails:masterfrom Sep 20, 2018
Merged
Update MySQL server version and character set in Rails Guide [skip ci]#33929kamipo merged 1 commit intorails:masterfrom
kamipo merged 1 commit intorails:masterfrom
Conversation
|
r? @sgrif (@rails-bot has picked a reviewer for you, use r? to override) |
Member
Author
|
This is my first pull request to Rails Guide. Would like to get feedback from the technical and English grammar point of views. |
kamipo
reviewed
Sep 20, 2018
guides/source/configuring.md
Outdated
Member
There was a problem hiding this comment.
I think "Rails 6 drops supporting MySQL 5.1" part is unnecessary for the guide, since we also didn't mention about which Rails version supports MySQL 5.0.
Member
Author
There was a problem hiding this comment.
Make sense. Updated and made some additional changes.
yahonda
force-pushed
the
update_utf8mb4_railsguide
branch
from
c428772 to
abba020
Compare
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Oct 30, 2018
rails#33853 and rails#33929 removed `encoding: utf8mb4` from database.yml since at that time MySQL 5.1 is supported with the master branch. Since MySQL 5.1 has been dropped, we can restore `encoding: utf8mb4` in database.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates MySQL server version and character set in Rails Guide [skip ci]
Related to #33853