Skip to content

Use frozen-string-literal in ActiveSupport#29728

Merged
matthewd merged 1 commit intorails:masterfrom
kirs:frozen-activesupport
Jul 9, 2017
Merged

Use frozen-string-literal in ActiveSupport#29728
matthewd merged 1 commit intorails:masterfrom
kirs:frozen-activesupport

Conversation

@kirs
Copy link
Copy Markdown
Member

@kirs kirs commented Jul 9, 2017

My previous plan to enable frozen-string-literal across all Rails gems didn't work (#29540) and had to be reverted because not all components were ready for it. Let's take a more incremental approach of enabling it per gem with the rubocop Only option, only for gems that we know are ready for frozen string.

Style/FrozenStringLiteralComment:
  Enabled: true
  EnforcedStyle: always
  Include:
    - 'activesupport/**/*'

Thanks to @pat 's work, activesupport is now ready for frozen string literal.

Once #29655 is merged, I'll do the same for the rest of components.

@rafaelfranca @matthewd

@rails-bot
Copy link
Copy Markdown

r? @kaspth

(@rails-bot has picked a reviewer for you, use r? to override)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants