Use frozen-string-literal in ActiveSupport#29728
Merged
matthewd merged 1 commit intorails:masterfrom Jul 9, 2017
kirs:frozen-activesupport
Merged
Use frozen-string-literal in ActiveSupport#29728matthewd merged 1 commit intorails:masterfrom kirs:frozen-activesupport
matthewd merged 1 commit intorails:masterfrom
kirs:frozen-activesupport
Conversation
|
r? @kaspth (@rails-bot has picked a reviewer for you, use r? to override) |
This was referenced Jul 16, 2017
This was referenced Jul 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My previous plan to enable frozen-string-literal across all Rails gems didn't work (#29540) and had to be reverted because not all components were ready for it. Let's take a more incremental approach of enabling it per gem with the rubocop
Onlyoption, only for gems that we know are ready for frozen string.Thanks to @pat 's work, activesupport is now ready for frozen string literal.
Once #29655 is merged, I'll do the same for the rest of components.
@rafaelfranca @matthewd