Enforce frozen string in Rubocop#29540
Merged
matthewd merged 1 commit intorails:masterfrom Jul 1, 2017
kirs:rubocop-frozen-string
Merged
Enforce frozen string in Rubocop#29540matthewd merged 1 commit intorails:masterfrom kirs:rubocop-frozen-string
matthewd merged 1 commit intorails:masterfrom
kirs:rubocop-frozen-string
Conversation
|
r? @matthewd (@rails-bot has picked a reviewer for you, use r? to override) |
Contributor
|
Thanks for sorting this out @kirs! 👏 |
Member
Author
|
ping @rafaelfranca - I rebased it against master. |
Contributor
|
Although I really like to see this as reality I'm pretty sure this should be done on waves, by packages or sections, not as a single PR. There's enough time to plan and organize what comes first or later. |
matthewd
added a commit
that referenced
this pull request
Jul 1, 2017
Enforce frozen string in Rubocop
Member
|
Reverted because I got ahead of myself; #29506 wasn't enough to make this green. |
Member
Author
|
I'll work on fixing those failures. |
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Jul 1, 2017
Since rails#29540, `# frozen_string_literal: true` included original migration files.
This was referenced Jul 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #29506 (comment), we should be able to enable
Style/FrozenStringLiteralCommentrule in Rubocop and add the magic comment to all files.@matthewd @rafaelfranca @pat