Skip to content

Comments

Fix ActionController::Parameters#== bug#23167

Merged
rafaelfranca merged 1 commit intorails:masterfrom
maclover7:fix-21032
Jan 21, 2016
Merged

Fix ActionController::Parameters#== bug#23167
rafaelfranca merged 1 commit intorails:masterfrom
maclover7:fix-21032

Conversation

@maclover7
Copy link
Contributor

See bug #21032.

cc @sikachu

@maclover7 maclover7 added this to the 5.0.0 milestone Jan 21, 2016
rafaelfranca added a commit that referenced this pull request Jan 21, 2016
Fix `ActionController::Parameters#==` bug
@rafaelfranca rafaelfranca merged commit 6fcc3c4 into rails:master Jan 21, 2016
@maclover7 maclover7 deleted the fix-21032 branch January 21, 2016 22:35
@maclover7
Copy link
Contributor Author

❤️

@sikachu
Copy link
Member

sikachu commented Jan 21, 2016

Thanks!

@maclover7
Copy link
Contributor Author

❤️ 💚 💙 💛 💜

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably needs expansion?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say we just remove it altogether. It's fixing the new unreleased parameters, not the one from 4.2.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Done here #23178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants