Allow options for :enum and provide :nested option to create namespaced scopes and methods#13433
Closed
imanel wants to merge 1 commit intorails:masterfrom
Closed
Allow options for :enum and provide :nested option to create namespaced scopes and methods#13433imanel wants to merge 1 commit intorails:masterfrom
imanel wants to merge 1 commit intorails:masterfrom
Conversation
…ed scopes and methods
imanel
referenced
this pull request
Dec 21, 2013
… values map to integers in the database, but can be queried by name
Member
|
Agree with @dhh here db41eb8#commitcomment-4922983. Thank you so muck for the contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is related to #13389 and should solve problems (1), (2) and (3) by allowing to create namespaces in such cases.
What is provided by this pull request?
Unfortunately I had to change API of enum from
to:
to make sure that options are extracted. If anyone has idea how to implement it without changing API then I will be glad to modify this pull request, but we might also think about potential other options in future and try to change API now - it's up to community.
EDIT: I'm considering changing option from "nested" to "prefix", but I will gladly hear what community have to say.