Need to add changelog

@rafaelfranca I've made some changes, can you have a look? Cheers.

Hey guys, I just rebased this branch and added a README.md entry, what can I do to wrap this up ?

• The changelog doesn't seem to match the change.
• I'm not sure we want to include 'ENGINE=InnoDB' on every table definition... maybe only if it differs from the default?
• You haven't removed the with_indifferent_access call you said you were going to.

What's wrong with the changelog ? English is not my first language so maybe I wrote something wrong, I could rephrase like :

"Allow to pass an engine option to the create_table method to be able to choose any MySQL Engine"

Ok for the two other points, I'll try to update the pull request tonight or tomorrow.

It's just Wrong: it describes a syntax engine: 'InnoDB', whereas the code implements options: 'ENGINE=InnoDB'.

Indeed, sorry for the confusion, this was not my work originally.

So what do you prefer ? Passing an :engine option or allowing to add any options with the :options option ?

BTW I'd go for the :engine way because it's easy to dump the engine but it would be a mess to dump all the updated options of the table.

Well, this goes back to @jeremy's concerns on #8242; should we be handling all the possible table options? What about PostgreSQL's equivalent construct?

IMO, a top-level :engine option gives a questionable amount of special significance to it... what if we implement options: { engine: 'InnoDB' } for now? That seems to leave the door open for us to blindly use the entire contents of the :options hash in future.

The problem with options: {engine: 'InnoDB'} is that at the moment, we can pass any MySQL option in the :options hash, for example, options: 'Engine=InnoDB, INSERT_METHOD = LAST

In order to be backward compatible, the best way would be to retrieve the non-default values of the table and dump them.

This is probably hard, since they may vary depending on the mysql version, etc :(

Thanks for picking up the work on this, @Intrepidd! :) Super appreciated.

Is the request still valid? @Intrepidd, are you working on it?

This PR is stale and I don't have the time to work on it at the moment. There were too many questions, help from a core team member would be really beneficial but I'm not sure if lots of people need this feature.

Hehe. Same thing happened to me with #8242, @Intrepidd

@repinel @Intrepidd @kenmazaika #17569 was merged, the PR contains the feature that ENGINE name specifying.

Thank you for the pull request. It is now possible with the options parameter to create table. create_table :foo, options: "ENGINE=MyISAM"