-
Notifications
You must be signed in to change notification settings - Fork 22.2k
Remove new_framework_defaults.rb from newly generated apps #28291
Description
Hello,
I take the liberty to open this ticket to discuss about the future of the new_framework_defaults.rb file. We've discussed about that with @matthewd and came to the conclusion that this file shouldn't be generated as it is done at the moment.
Actually, it would be easier to generate a file on a version basis like new_framework_defaults_51.rb with only the new defaults for this version.
An important thing to consider with this approach though is that this file takes precedence over any file stored under config/environments and may take precedence over certain initializers since they are alphabetically required (AFAIK). So if people want to opt out from the default, we should maybe require initializers that match new_framework_default_*.rb first.
By the way, since 5.0, it looks like only this option has been changed and this one has been removed.
To-do:
- No longer generate this file for new 5.1 applications so properly set the configuration settings in the appropriate configuration files.
- During the upgrade process (i.e. running
bin/rails app:upgrade), generate a file tied to the current version with the new settings.
Have a nice day !