Fix scaffold controller generator with namespace#512
Merged
dhh merged 4 commits intorails:masterfrom Dec 16, 2021
Merged
Conversation
ceritium
force-pushed
the
fix-scaffold-controller-namespace
branch
from
1e80e6a to
71fdf4a
Compare
ceritium
changed the title
ceritium
force-pushed
the
fix-scaffold-controller-namespace
branch
from
3d443bf to
00c99b0
Compare
ceritium
changed the title
For example: ``` bundle exec rails g scaffold_controller Admin::Post title:string content:text --model-name=Post ``` It fixes the code generated by jbuilder, other changes are required on railties gem.
Only for Rails::VERSION::MAJOR >= 6 because the method `show_helper` doesn't handle well the namespaces on previous versions.
ceritium
force-pushed
the
fix-scaffold-controller-namespace
branch
from
00c99b0 to
56d333b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example:
It fixes the code generated by jbuilder. There is another fix on railties gem.
You can QA it modifying the Gemfile with:
And run the following generators for example:
Then you can see the code and test the generated scaffold.