Add rich_text, attachment, and attachments fields support#459
Merged
dhh merged 1 commit intorails:masterfrom Jan 22, 2021
Merged
Conversation
excid3
force-pushed
the
add-rich_text-and-attachment-fields-support
branch
from
dee2b0f to
952f675
Compare
Contributor
Author
|
@rafaelfranca wanted to bump this. Would you consider merging this one since Rails 6 already has these generator fields in rails/rails#35805? Jbuilder overrides the generators so they would appear to not work in a new Rails 6 app until jbuilder is also updated. Thanks! |
|
Voicing my support for this functionality |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just added support for generating models with
rich_text,attachmentandattachmentsfields for ActionText and ActiveStorage to Rails 6 recently.This updates jbuilder's scaffold generator to also support these fields and retains the old functionality for older Rails versions.