Improve package manager detection for Bun 1.2 compatibility - #165
Conversation
- Add support for both old (bun.lockb) and new (bun.lock) Bun lock files - Handle Bun with Yarn compatibility mode (yarn.lock) - Simplify tool detection by introducing LOCK_FILES mapping - Combine command existence and lock file checks into single method This change ensures proper detection of Bun when using different versions or when running in Yarn compatibility mode (bun install --yarn).
|
Looks good to me. Please do add a PR with tests. |
|
It looks like this update changes the detection logic. Now, if I have |
|
Ah. Please do investigate a PR to flip that back. Thanks for catching! |
| File.exist?('bun.lockb') || (tool_exists?('bun') && !File.exist?('yarn.lock')) | ||
| tool_exists?('bun') && (File.exist?('bun.lockb') || | ||
| File.exist?('bun.lock') || | ||
| File.exist?('yarn.lock')) |
There was a problem hiding this comment.
When a system has both bun installed alongside a project that uses Yarn (presence of a yarn.lock file)
We should remove any conditional checks for yarn.lock from bun related lines.
Even though Bun can technically manage
yarn.lockfile.
Keeping these existence checks may lead to use of bun when you were using yarn before this PR has been merged and want to keep using yarn for the project.
| extend self | ||
|
|
||
| LOCK_FILES = { | ||
| bun: %w[bun.lockb bun.lock yarn.lock], |
|
@navidemad @nikitug @dhh |
4 participants
I'm using bun and install packages with
bun install --yarnand its generate a yarn.lock file, same time new version of bun 1.2 generatesbun.lockfile instead ofbun.lockb.Some users may have bun with
yarn.lockfile or bun withbun.lockMy assets recompilation failed with:
Here is a proposal to handle this, idk what best way to do this. If this way looks ok I can fix test as well. Also we have
using_bun?method atHelpersmodule that dose not check forbun.lockand return false if bun exists and yarn.lock presentbun.lockband newbun.lockBun lock filesyarn.lock