Updates for frozen string literal compatibility.#6
Merged
tenderlove merged 1 commit intorails:masterfrom Feb 18, 2019
Merged
Conversation
Author
|
A better before_script:
- if (ruby -e "exit RUBY_VERSION.to_f >= 2.4"); then export RUBYOPT="--enable-frozen-string-literal"; fi; echo $RUBYOPT |
pat
added a commit
to pat/rails
that referenced
this pull request
Jun 20, 2017
The ActiveSupport test suite only passes currently if it uses the latest unreleased commits for dalli, and a patch for Builder: rails/builder#6 Beyond that, all external dependencies (at least, to the extent they’re used by ActiveSupport) are happy, including Nokogiri as of 1.8.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes allow the test suite to pass with
RUBYOPT="--enable-frozen-string-literal".If you wanted, you can update
.travis.ymlto include the following, which automatically enables that flag against MRI 2.4.1 (thus picking up regressions). It'd be nice if it worked reliably for future MRI releases and ruby-head though (I'll ponder a better way of doing this that covers those scenarios).