Accept static route for transfer request #7349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netcriptus
force-pushed
the
feature/send-route-metadata
branch
from
dc8d74f to
45c7271
Compare
konradkonrad
suggested changes
Sep 15, 2021
Contributor
konradkonrad
left a comment
konradkonrad
left a comment
There was a problem hiding this comment.
looks good code wise, two change requests though:
- please add REST API documentation
- please see my comments about the integration test for
test_api_payments_without_pfs
netcriptus
force-pushed
the
feature/send-route-metadata
branch
2 times, most recently
from
79fc292 to
0cd149f
Compare
netcriptus
force-pushed
the
feature/send-route-metadata
branch
from
0cd149f to
22d3771
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.