-
Notifications
You must be signed in to change notification settings - Fork 374
Enable WebRTC #7195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable WebRTC #7195
Conversation
fredo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left some comments below.
Additionally, in web_rtc.py in line 428 this needs to be changed to via matrix to_device message as room usage is outdated
19d735f to
bc1373d
Compare
3b4b1c7 to
68f2fc7
Compare
fredo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, but please have a look again if removing the if condition was the right thing to do.
68f2fc7 to
d15e0a3
Compare
Also enable WebRTC.
f1beef4 to
7189295
Compare
Also switch to PFS routing mode when doing a smoketest.
It's not usable because we need to provide valid metadata, which includes correctly signed user IDs.
Instead of calling query_address_metadata and query_paths directly, we should now call methods on PFSProxy. This allows us to tweak the behaviour and provide valid metadata in tests more easily.
RaidenService is a Runnable, which implements __bool__ that checks whether the greenlet is running, which is not what we want to test here. Instead, we'd like to check against None, but since the service will not be None here, remove the check completely.
886ca5a to
1140608
Compare
This PR adds the metadata querying during WebRTC signaling which was the last remaining thing needed to enable WebRTC.