Skip to content

Conversation

@istankovic
Copy link
Contributor

This PR adds the metadata querying during WebRTC signaling which was the last remaining thing needed to enable WebRTC.

@auto-assign auto-assign bot requested a review from fredo June 29, 2021 10:34
Copy link
Contributor

@fredo fredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some comments below.

Additionally, in web_rtc.py in line 428 this needs to be changed to via matrix to_device message as room usage is outdated

@istankovic istankovic force-pushed the webrtc-metadata branch 5 times, most recently from 19d735f to bc1373d Compare July 8, 2021 07:35
Copy link
Contributor

@fredo fredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, but please have a look again if removing the if condition was the right thing to do.

@istankovic istankovic force-pushed the webrtc-metadata branch 2 times, most recently from f1beef4 to 7189295 Compare July 15, 2021 14:12
Ivan Stanković added 15 commits July 15, 2021 19:03
Also switch to PFS routing mode when doing a smoketest.
It's not usable because we need to provide valid metadata,
which includes correctly signed user IDs.
Instead of calling query_address_metadata and query_paths directly,
we should now call methods on PFSProxy. This allows us to tweak the
behaviour and provide valid metadata in tests more easily.
RaidenService is a Runnable, which implements __bool__ that checks
whether the greenlet is running, which is not what we want to test here.
Instead, we'd like to check against None, but since the service will
not be None here, remove the check completely.
@fredo fredo merged commit 54c6b82 into raiden-network:develop Jul 16, 2021
@istankovic istankovic deleted the webrtc-metadata branch July 16, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants